-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: logits -> probs in Accuracy metric documentation #5340
Merged
rohitgr7
merged 5 commits into
Lightning-AI:master
from
Kulikovpavel:bugfix/metrics-documentation-accuracy-logits
Jan 4, 2021
Merged
docs: logits -> probs in Accuracy metric documentation #5340
rohitgr7
merged 5 commits into
Lightning-AI:master
from
Kulikovpavel:bugfix/metrics-documentation-accuracy-logits
Jan 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Kulikovpavel pls return the checklist to the PR description, it is there on purpose... |
Codecov Report
@@ Coverage Diff @@
## master #5340 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 134 134
Lines 9950 9950
======================================
- Hits 9261 9254 -7
- Misses 689 696 +7 |
awaelchli
reviewed
Jan 3, 2021
rohitgr7
reviewed
Jan 3, 2021
rohitgr7
approved these changes
Jan 4, 2021
SkafteNicki
approved these changes
Jan 4, 2021
Borda
approved these changes
Jan 4, 2021
justusschock
approved these changes
Jan 4, 2021
tchaton
approved these changes
Jan 4, 2021
Borda
pushed a commit
that referenced
this pull request
Jan 6, 2021
* fix: logits -> probs in accuracy metrics documentation * Update metrics.rst * Update metrics.rst Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 15a400b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Documentation fix for Accuracy metric
There should be probs instead of logits as input.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃