Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit hook failures. #5387

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

arnaudgelas
Copy link
Contributor

@arnaudgelas arnaudgelas commented Jan 6, 2021

What does this PR do?

Fixes #5386

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@arnaudgelas arnaudgelas force-pushed the fix/pre-commit-failures branch from 60e88a9 to e9253d4 Compare January 6, 2021 20:13
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #5387 (e9253d4) into master (cc62435) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5387   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9994    9994           
======================================
  Hits         9309    9309           
  Misses        685     685           

@Borda Borda enabled auto-merge (squash) January 6, 2021 23:28
@Borda Borda added priority: 2 Low priority task refactor labels Jan 6, 2021
@Borda Borda added this to the 1.1.x milestone Jan 6, 2021
@Borda Borda added the ready PRs ready to be merged label Jan 6, 2021
@rohitgr7 rohitgr7 merged commit 4c6f36e into Lightning-AI:master Jan 7, 2021
Borda pushed a commit to arnaudgelas/pytorch-lightning that referenced this pull request Jan 7, 2021
SeanNaren pushed a commit that referenced this pull request Jan 12, 2021
SeanNaren pushed a commit that referenced this pull request Jan 12, 2021
SeanNaren pushed a commit that referenced this pull request Jan 13, 2021
SeanNaren pushed a commit that referenced this pull request Jan 13, 2021
SeanNaren pushed a commit that referenced this pull request Jan 19, 2021
Borda pushed a commit that referenced this pull request Jan 23, 2021
Borda pushed a commit that referenced this pull request Jan 25, 2021
Borda pushed a commit that referenced this pull request Jan 26, 2021
Borda pushed a commit that referenced this pull request Jan 26, 2021
Borda pushed a commit that referenced this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 2 Low priority task ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit failures
6 participants