Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add section & add testing ckpt 1.1.4 #5495

Merged
merged 6 commits into from
Jan 14, 2021
Merged

add section & add testing ckpt 1.1.4 #5495

merged 6 commits into from
Jan 14, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 13, 2021

What does this PR do?

add a new section after 1.1.4 release
add testing of legacy 1.1.4

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added docs Documentation related ci Continuous Integration labels Jan 13, 2021
@Borda Borda added this to the 1.1.x milestone Jan 13, 2021
@Borda Borda marked this pull request as draft January 13, 2021 10:57
@Borda Borda marked this pull request as ready for review January 13, 2021 11:21
@Borda
Copy link
Member Author

Borda commented Jan 13, 2021

seems like NumPy docs is temp down...

intersphinx inventory 'https://numpy.org/doc/stable/objects.inv' not fetchable due to <class 'requests.exceptions.HTTPError'>: 404 Client Error: Not Found for url: https://numpy.org/doc/stable/objects.inv

@Borda Borda enabled auto-merge (squash) January 13, 2021 11:27
@Borda Borda added the ready PRs ready to be merged label Jan 13, 2021
@Borda Borda self-assigned this Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #5495 (3b96095) into master (d916973) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #5495    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         135     135            
  Lines       10003    9863   -140     
=======================================
- Hits         9326    9173   -153     
- Misses        677     690    +13     

@Borda
Copy link
Member Author

Borda commented Jan 13, 2021

the remaining ckpt 1.1.4 was created by #5494

@awaelchli awaelchli disabled auto-merge January 14, 2021 00:29
@awaelchli awaelchli merged commit 94b7d84 into master Jan 14, 2021
@awaelchli awaelchli deleted the docs/changelog branch January 14, 2021 00:29
Borda added a commit that referenced this pull request Feb 4, 2021
* add section

* test legacy

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants