Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix auto-update conditions #5496

Merged
merged 3 commits into from
Jan 13, 2021
Merged

fix auto-update conditions #5496

merged 3 commits into from
Jan 13, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 13, 2021

What does this PR do?

it turns out the #5451 (comment) was an incorrect suggestion (and I missed it) as if there is conflict it cannot be updated so in fact no update was made...

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added priority: 0 High priority task ci Continuous Integration labels Jan 13, 2021
@Borda Borda added this to the 1.1.x milestone Jan 13, 2021
@Borda Borda requested a review from tchaton as a code owner January 13, 2021 11:48
@Borda Borda added the ready PRs ready to be merged label Jan 13, 2021
@Borda Borda enabled auto-merge (squash) January 13, 2021 11:54
@Borda Borda self-assigned this Jan 13, 2021
@Borda Borda merged commit 4c78804 into master Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #5496 (5a0503e) into master (36198ec) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #5496    +/-   ##
=======================================
- Coverage      93%     93%    -0%     
=======================================
  Files         135     135            
  Lines       10015    9875   -140     
=======================================
- Hits         9338    9185   -153     
- Misses        677     690    +13     

@Borda Borda deleted the ci/fix-update branch January 13, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants