Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

58 upload fip file directly #65

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

58 upload fip file directly #65

wants to merge 19 commits into from

Conversation

shashankmc
Copy link
Contributor

This pull caters two things -

  1. FIP parsing through nanopub link (not the best way of parsing but does the job for now)
  2. Local file upload (file here means "fip file") - This is arguable because we might want to upload even the cedar template and shacl file from local. While shacl loads fine, cedar template loading fails in such cases.

shashankmc and others added 15 commits February 9, 2023 16:44
@shashankmc
New service for communicating with Nanopub services
60ca164
@shashankmc
Modified fip controller with new nanopub service
74022c5
@shashankmc
Added new package dependency nanopub
5f49019
Conditional check for ttl files catering to all scenarios
63e27b7
corrected a stupid regex error
79914dc
Removed default value, corrected return fip value, added new method i…
0d9731c 
…n class to handle fetch connection refused error
Control checks
b3ed5be
Modifying UI for local file upload use case
f525705
@shashankmc
modified check
e2f1cf9
@shashankmc
modified check
4d8a6d7
@shashankmc
removing unnecessary print
0d1c8fe
@shashankmc
providing the correct url for shacl
f2a263e
@shashankmc
condition correction, wasn't working as expected
5836cd8
@shashankmc
added a temp method to check if extraction was working as expected. B…
05531d6 
…etter to move it to fip services
@shashankmc
restructured, added more conditions to cover file upload, nanopub lin…
a89406c 
…k for fip
@shashankmc shashankmc requested review from matthijssloep and aiaragomes and removed request for matthijssloep March 6, 2023 12:02
@shashankmc
Copy link
Contributor Author

@aiaragomes

  1. Modified code to query nanopub sparql endpoint rather than iterations (significant time reduction).
  2. Modified front end for the user to select the necessary method of upload rather than overdose with them options.
  3. A little code clean up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aiaragomes aiaragomes Awaiting requested review from aiaragomes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shashankmc