Initial modifications to SConstruct to add blackberry #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG - Added blackberry target to the SConstruct file - Removed unused variables Note: as git doesn't seem to track empty dirs, the script will complain that blackberry dir doesn't exist until it's created TESTS - Verified that the mobile sdk still builds correctly for Android - Verified that "scons blackberry=1" Prints the Building for Blackberry message and packages and returns - Verified that scons without params builds both android and blackberry (the full clause)
|
Looks ok for now! |
the script to exit skipping the packaging step. Changelog: - Catch the exception and log it to stdout Test: - Verified doing a full build still packages the android mobile sdk when blackberry folder doesn't exist
|
Approved |
jpl-mac
pushed a commit
that referenced
this pull request
Mar 22, 2012
Initial modifications to SConstruct to add blackberry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Note: as git doesn't seem to track empty dirs, the script will complain
that blackberry dir doesn't exist until it's created
TESTS
message and packages and returns
(the full clause)