-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aggregate report process #45
Add aggregate report process #45
Conversation
7ae1af3
to
5631ebf
Compare
action.yml
Outdated
@@ -26,6 +26,10 @@ inputs: | |||
description: "Run the action in debug mode and get debug logs printed in console" | |||
required: false | |||
default: "false" | |||
aggregate-mode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this?
I yet to try configuring "jacoco-playground" repo to generate aggregated report. But from your test cases, I saw the XML of the generated file. Can't we just check for the presence of "" and then figure out it's in aggregate-mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the DTD for the jacoco report xml, we have "<group>" which the github-action currently doesn't support. I will use your PR to add support for that. I am going to remove the "aggregate-mode" flag, and keep the rest.
… add-aggregate-report-process # Conflicts: # README.md # dist/index.js # src/action.js
The DTD is not fully supported. There are still cases like "group can exist within group", "report can contain both group and package"... |
The ability to be able to process aggregate reports generated by Jacoco is added in this pr.
The functionality is enabled by setting
aggregate-mode
to truefixes #40