Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

chore(Python): added 0/1 knapsack problem #415

Merged
merged 3 commits into from
Aug 20, 2021
Merged

chore(Python): added 0/1 knapsack problem #415

merged 3 commits into from
Aug 20, 2021

Conversation

canhuynh1998
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • New algorithm
  • Optimization in previous algorithms
  • Code style update
  • Refactor
  • Documentation
  • Other, please describe:

Briefly describe the changes in this PR
0/1 Knapsack Problem using Dynamic Programming and implemented using Python

@welcome
Copy link

welcome bot commented Aug 15, 2021

Thanks for opening this pull request! Please check out our contributing guidelines.

@ming-tsai ming-tsai changed the title Added 0/1 Knapsack Problem chore(Python): added 0/1 Knapsack Problem Aug 17, 2021
@ming-tsai ming-tsai requested a review from Arsenic-ATG August 17, 2021 12:59
@ming-tsai ming-tsai added the Python language used is python label Aug 17, 2021
@ming-tsai ming-tsai changed the title chore(Python): added 0/1 Knapsack Problem chore(Python): added 0/1 knapsack problem Aug 17, 2021
@ming-tsai ming-tsai requested review from atinba and removed request for Arsenic-ATG August 17, 2021 13:25
@canhuynh1998
Copy link
Contributor Author

Can someone let me know what test did I fail? I am not really sure.

@ming-tsai
Copy link
Member

Can someone let me know what test did I fail? I am not really sure.

Don't worry, the failed action is not affecting by your code

@canhuynh1998
Copy link
Contributor Author

Thank you! Just making sure that I didn't do anything wrong along the way.

@ming-tsai ming-tsai requested review from sridhar-5 and removed request for atinba August 18, 2021 14:00
@sridhar-5
Copy link
Member

Hello @ming-tsai long time,
I will review this in a few moments now.

@ming-tsai
Copy link
Member

Hello @ming-tsai long time,
I will review this in a few moments now.

Yeah...

Copy link
Member

@sridhar-5 sridhar-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your codebooks good to me @canhuynh1998. How ever there is a failing test. as per our organisations rules and regulations a pull request with failing tests cannot be merged. you can refer this link to resolve your failing tests. for further help ping here.

@canhuynh1998
Copy link
Contributor Author

@sridhar-5 thank you, for some reason, I cannot access the link you provided.

@sridhar-5
Copy link
Member

sridhar-5 commented Aug 19, 2021

@sridhar-5 thank you, for some reason, I cannot access the link you provided.

can you try now? I've updated the comment. can you confirm if you are able to access?

@canhuynh1998
Copy link
Contributor Author

@sridhar-5 thank you, for some reason, I cannot access the link you provided.

can you try now? I've updated the comment. can you confirm if you are able to access?
Ok I got it right now. I will do it ASAP will let you know if I need any additional help

@canhuynh1998
Copy link
Contributor Author

I just tried to fix it based on the provided link. Please take a look whenever you are convenient @sridhar-5

@Arsenic-ATG
Copy link
Member

your codebooks good to me @canhuynh1998. How ever there is a failing test. as per our organisations rules and regulations a pull request with failing tests cannot be merged. you can refer this link to resolve your failing tests. for further help ping here.

@sridhar-5 the failing labeler test has nothing to do with this PR, looks like the test is either not implemented properly or in process of begin implemented.

Even @ming-tsai mentioned it above in the conversation here. : -

Can someone let me know what test did I fail? I am not really sure.

Don't worry, the failed action is not affecting by your code

Copy link
Member

@sridhar-5 sridhar-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to Me @ming-tsai. If failing test isn't a problem. we can take this forward and merge this pull request.

Nice work @canhuynh1998.

@ming-tsai ming-tsai merged commit 31418cd into MakeContributions:main Aug 20, 2021
@welcome
Copy link

welcome bot commented Aug 20, 2021

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉.
You are invited to join the team on Github and Discord.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Python language used is python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants