Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow node_size to overwrite automatic node size based on ilabels #145

Merged
merged 2 commits into from
Nov 26, 2023

Conversation

hexaeder
Copy link
Collaborator

should fix #144

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0cce3e) 80.44% compared to head (248e4f7) 80.52%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   80.44%   80.52%   +0.08%     
==========================================
  Files           5        5              
  Lines         721      724       +3     
==========================================
+ Hits          580      583       +3     
  Misses        141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hexaeder hexaeder mentioned this pull request Nov 15, 2023
@fredcallaway
Copy link
Contributor

This fix works, seems like it's being held up by an irrelevant test failure in the documentation generation?

@hexaeder hexaeder merged commit 2260b38 into master Nov 26, 2023
@hexaeder hexaeder deleted the hw/ilabelsnodesize branch November 26, 2023 17:08
@hexaeder
Copy link
Collaborator Author

oops forgot to follow up on this, should be released soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting node size with ilabel
3 participants