handle exception thrown by stripe when customer has no subscription

Marcusk19 · Jan 30, 2025 · 35843cc · 35843cc
1 parent c852217
commit 35843cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/workers/reconciliationworker.py b/workers/reconciliationworker.py
@@ -87,8 +87,12 @@ def _perform_reconciliation(self, user_api, marketplace_api):
             except stripe.error.InvalidRequestError:
                 logger.warn("Invalid request for stripe_id %s", user.stripe_id)
                 continue
+            try:
+                subscription = stripe_customer.subscription
+            except AttributeError:
+                subscription = None
             for sku_id in RECONCILER_SKUS:
-                if stripe_customer.subscription:
+                if subscription is not None:
                     plan = get_plan(stripe_customer.subscription.plan.id)
                     if plan is None:
                         continue

diff --git a/workers/test/test_reconciliationworker.py b/workers/test/test_reconciliationworker.py
@@ -41,6 +41,9 @@ def test_exception_handling(initialized_db):
     with patch("data.billing.FakeStripe.Customer.retrieve") as mock:
         mock.side_effect = stripe.error.APIConnectionError
         worker._perform_reconciliation(marketplace_users, marketplace_subscriptions)
+    with patch("data.billing.FakeStripe.Customer.subscription") as mock:
+        mock.side_effect = AttributeError
+        worker._perform_reconciliation(marketplace_users, marketplace_subscriptions)
 
 
 def test_create_for_stripe_user(initialized_db):