feat/rename methods and types #147
Conversation
MasterKale
added
package:browser
|
@MasterKale I think we will want to update the examples after we cut the 4.0.0 release. I can do that once its made it to the package distributors. What do you think? Also, there is a chance I will have to bug you whenever I go to fix these merge conflicts 😆 |
Aaaaah, sorry about that, I didn't think it'd cause any conflicts! Feel free to ping me about anything that doesn't make sense, I'm pretty sure these are due to the changes I merged in #151 😱 |
@MasterKale, It ended up being pretty easy. Are you okay with updating the examples after 4.0.0 is released? |
packages/server/src/authentication/verifyAuthenticationResponse.ts
Outdated
Show resolved
Hide resolved
|
Tests are failing from error assertions. They will be fixed once I settle on a more clear message #147 (comment) |
@JayHelton Absolutely, updating the example is part of my usual release duties (and one I look forward to because it's so satisfying to verify the results of the work that went into the release 😛) |
packages/server/src/authentication/verifyAuthenticationResponse.ts
Outdated
Show resolved
Hide resolved
|
@JayHelton This is a really solid effort so far, thank you for coordinating all this. I appreciate you renaming the attestation/ and assertion/ folders too 👍 |
|
@MasterKale feel free to start looking closely! I am doing self-reviews now through the changes. |
There was a problem hiding this comment.
Everything appears to be in order! Thank you for undertaking this effort, and for implementing those few refinements along the way. I'm sorry this PR wasn't more interesting! That said I think your work here will go a long way in making the project that much simpler to use, so you're definitely leaving your mark 💪
tl;dr: lgtm 
Changes:
renaming of SimpleWebAuthn specific methods and types to use 'Registration' instead of 'Attestation' and 'Authentication' instead of 'Assertion'.
This does not rename all types to conform to that lingo. Type definitions defining interfaces and types from Web API are kept with their documented names, i.e. AuthenticatorAttestationResponse and AuthenticationAssertionResponse.
Browser Package
Server Package
In Code Documentation/Comments