fix/mds-metadata-more-alg-support #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional mappings between FIDO Alliance authentication algorithms mappings to COSE values. The following algorithms are now supported when they appear in FIDO MDS statements:
rsa_emsa_pkcs1_sha256_rawrsa_emsa_pkcs1_sha256_derCOSE info for the following algorithms have also been updated:
secp256k1_ecdsa_sha256_rawsecp256k1_ecdsa_sha256_derAnd better debugging output is returned from errors like this to help with troubleshooting:
This PR should fix the second issue in #238.