Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/430-make-debug-logging-noop #434

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

MasterKale
Copy link
Owner

I'm disabling logging output for now while I investigate an alternative library to https://www.npmjs.com/package/debug. The fact that it requires @types/debug to also be installed is creating this catch-22 with dnt, specifically the Debugger type that comes from @types/debug.

In a Node project you'd re-export it like this after installing @types/debug:

export { Debugger, default as debug } from 'debug';

But Deno requires you to import Debugger from @types/debug specifically:

export { default as debug } from 'https://esm.sh/[email protected]';
export type { Debugger } from 'https://esm.sh/@types/[email protected]';

Unfortunately after dnt builds the project, trying to build a TypeScript project with tsc results in an error like the one reported in Issue #430:

node_modules/@simplewebauthn/server/script/deps.d.ts:6:31 - error TS6137: Cannot
import type declaration files. Consider importing 'debug' instead of '@types/debug'.

6 export type { Debugger } from '@types/debug';
                                ~~~~~~~~~~~~~~

Disabling logging now will give me time to research an alternative.

@MasterKale MasterKale merged commit 289bfcc into master Sep 4, 2023
@MasterKale MasterKale deleted the fix/430-make-debug-logging-noop branch September 4, 2023 19:16
@MasterKale MasterKale added the package:server @simplewebauthn/server label Sep 4, 2023
@MasterKale MasterKale added this to the v8.1.1 milestone Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:server @simplewebauthn/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant