fix(browser): handle undefined PublicKeyCredential in browserSupportsWebAuthnAutofill helper #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WebAuthnAutofill helper
|
Thank you for the PR @clarafitzgerald, but as per the README's Contributions section this project is not currently accepting external contributions. I still appreciate you taking the time to submit #544, which helped me quickly complete #557 to address the issue (along with getting some testing on this method.) Thank you for understanding 🙇 |
|
Wait a minute, I left the door open for external contributions for bug fixes 🤦♂️
I'm really sorry about that @clarafitzgerald, I forgot about that exception. I'll still give you credit in the release notes because this PR definitely qualified as a bugfix...sorry again 🫠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an early return to the
browserSupportsWebAuthnAutofillhelper function ifbrowserSupportsWebAuthnreturns false. This preventsbrowserSupportsWebAuthnAutofillfrom throwing aTypeErroron browsers without webauthn support.Closes #544