Review - Tests, Key and Certificate Generation, Concurrency Control, Custom TLS Verification

README.md

@@ -154,3 +154,58 @@ npm publish --access public
 git push
 git push --tags
 ```
+
+---
+
+I need to be locked together.
+
+These need to be atomic operations.
+
+The only issue is that the "atomicity" is controlled outside of `QUICConnection` atm.
+
+Whereas it seems to make sense to do this directly?
+
+```
+recieve
+[IF IS DRAINING IS TRUE SKIP SEND]
+send
+[CLOSE] - we may be "closed here"
+set-timeout
+```
+
+This would be triggered by:
+* QUICStream
+* keepAliveTimer
+* after onTimeout
+
+```
+send
+[CLOSE] - we may be "closed here"
+set-timeout
+```
+
+Remember you may also "receive" and end up closing too. But you will always check if you need to send first before checking the close. At worst it will tell you it's done.
+
+Now of course we enable calling recv and send.
+
+But `send` actually ends up calling multiple things here.
+
+But if `recv` is synchronous, you can always call it infront of `send`.
+
+This technically means `send` should be encapsulating the logic of setting the timeout.
+
+If you want to make sure it's re-entrant, you can just "lock" on the send call.
+
+The setTimeout is then protected.
+
+The `recv` call is made synchronously.
+
+
+
+Receive Send Timer, Send Timer (all of this requires locking the conn lock)
+
+Closing too, it should require the conn lock
+Receive Send [Close] Timer, Send [Close] Timer
+It's all optional
+It's the send that has to do Send, Close, Timer... that's what needs to check it all
+Forget about events for now

benches/stream_1KB.ts

@@ -16,15 +16,6 @@ async function main() {
     ),
   ]);
   // Setting up initial state
-  const crypto = {
-    key: await testsUtils.generateKey(),
-    ops: {
-      sign: testsUtils.sign,
-      verify: testsUtils.verify,
-      randomBytes: testsUtils.randomBytes,
-    },
-  };
-
   const data1KiB = Buffer.alloc(1024, 0xf0);
   const host = '127.0.0.1' as Host;
   const certChainPem = await fs.promises.readFile(
@@ -36,14 +27,18 @@ async function main() {
 
   const quicServer = new QUICServer({
     config: {
-      tlsConfig: {
-        privKeyPem: privKeyPem.toString(),
-        certChainPem: certChainPem.toString(),
-      },
+      key: privKeyPem.toString(),
+      cert: certChainPem.toString(),
       verifyPeer: false,
+      keepAliveIntervalTime: 1000,
+    },
+    crypto: {
+      key: await testsUtils.generateKeyHMAC(),
+      ops: {
+        sign: testsUtils.signHMAC,
+        verify: testsUtils.verifyHMAC,
+      },
     },
-    keepaliveIntervalTime: 1000,
-    crypto,
     logger,
   });
   quicServer.addEventListener(
@@ -80,7 +75,11 @@ async function main() {
     host,
     port: quicServer.port,
     localHost: host,
-    crypto,
+    crypto: {
+      ops: {
+        randomBytes: testsUtils.randomBytes,
+      },
+    },
     logger,
   });
 

jest.config.js

@@ -33,8 +33,21 @@ module.exports = {
   roots: ['<rootDir>/tests'],
   testMatch: ['**/?(*.)+(spec|test|unit.test).+(ts|tsx|js|jsx)'],
   transform: {
-    '^.+\\.tsx?$': 'ts-jest',
-    '^.+\\.jsx?$': 'babel-jest',
+    "^.+\\.(t|j)sx?$": [
+      "@swc/jest",
+      {
+        jsc: {
+          parser: {
+            syntax: "typescript",
+            tsx: true,
+            decorators: compilerOptions.experimentalDecorators,
+            dynamicImport: true,
+          },
+          target: compilerOptions.target.toLowerCase(),
+          keepClassNames: true,
+        },
+      }
+    ],
   },
   reporters: [
     'default',