Nodejs18 not supported anymore on Ubuntu 18.04 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giffels
requested review from
a team,
eileen-kuehn and
rfvc
and removed request for
a team
eileen-kuehn
previously approved these changes
Feb 23, 2023
giffels
force-pushed
the
fix/docker-builds-nodejs
branch
from
6a8a86b to
410f15d
Compare
Codecov ReportBase: 98.80% // Head: 98.80% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 56 56
Lines 2339 2339
=======================================
Hits 2311 2311
Misses 28 28 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Solved a merge conflict, so @eileen-kuehn and @rfvc could reapprove, please? |
eileen-kuehn
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to nodesource/distributions#1392 Nodejs18 is not supported anymore on Ubuntu 18.04, so this pull request downgrades the version used to Nodejs16, like for Centos7.
Anyhow Ubuntu 18.04 will be depracted in April 2023 and therefore removed from deployment tests. See #288.