Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description (for docs index page) #185

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Feb 2, 2024

Update description to contain more information suitable for the reference index page in the docs. Tested out the rendering and links, and it looks like the following:

Screenshot 2024-02-06 at 11 32 26 AM

Fixes MetaMask/metamask-docs#1024

@alexandratran alexandratran requested a review from a team as a code owner February 2, 2024 02:52
@vandan
Copy link
Contributor

vandan commented Feb 2, 2024

Should we say anything about the fact that the links to the API reference are in the left nav? I know it seems obvious, but I think we might get better conversion rates if there's at least a hint (something short of redundantly listing the methods in the body of the page, of course).

@alexandratran
Copy link
Contributor Author

@vandan The second paragraph starts with:

View the JSON-RPC API methods by selecting them in the left sidebar.

@alexandratran alexandratran requested a review from jiexi February 2, 2024 17:46
Copy link
Contributor

@jiexi jiexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@vandan vandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran alexandratran merged commit 9f21fde into MetaMask:main Feb 6, 2024
5 checks passed
@alexandratran alexandratran deleted the 1024-update-index branch February 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RPC API reference index page
3 participants