Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add EncryptionKey type parameter to ExportableKeyEncryptor #5395

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Feb 26, 2025

Explanation

The ExportableKeyEncryptor type used to identify encryptor that support exported keys has been made generic, with a type parameter EncryptionKey to let the consumer define the type of key that will be used for encryption (e.g. CryptoKey). The type parameter defaults to unknown, making this non-breaking.

References

Changelog

@metamask/keyring-controller

  • CHANGED: The ExportableKeyEncryptor is now a generic type with a type parameter EncryptionKey (#5395)
    • The type parameter defaults to unknown

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mikesposito mikesposito marked this pull request as ready for review February 26, 2025 10:01
@mikesposito mikesposito requested review from a team as code owners February 26, 2025 10:01
@mikesposito mikesposito changed the title refactor: add generic EncryptionKey type to ExportableKeyEncryptor refactor: add EncryptionKey type parameter to ExportableKeyEncryptor Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant