-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: profile sync controllers should consume SDK methods #5413
Draft
mathieuartu
wants to merge
7
commits into
main
Choose a base branch
from
refactor/profile-sync-controllers-consume-sdk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR makes the necessary changes so that
UserStorageController
andAuthenticationController
consumes the SDK.That means that there's no longer controller specific logic nor services related to authentication and user storage.
Test coverages has also been increased to almost 100% for all things related to authentication and user storage, for controller & SDK.
References
Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-48
Changelog
@metamask/profile-sync-controller
UserStorageController
andAuthenticationController
now use the SDK under the hoodUserStorageController
cannot use the'AuthenticationController:performSignOut'
action anymore@metamask/notification-services-controller
Checklist