Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: profile sync controllers should consume SDK methods #5413

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Feb 28, 2025

Explanation

This PR makes the necessary changes so that UserStorageController and AuthenticationController consumes the SDK.
That means that there's no longer controller specific logic nor services related to authentication and user storage.
Test coverages has also been increased to almost 100% for all things related to authentication and user storage, for controller & SDK.

References

Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-48

Changelog

@metamask/profile-sync-controller

  • CHANGED: UserStorageController and AuthenticationController now use the SDK under the hood
  • CHANGED(BREAKING): UserStorageController cannot use the 'AuthenticationController:performSignOut' action anymore

@metamask/notification-services-controller

  • CHANGED: Change import for mock access token (only related to tests)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity label Feb 28, 2025
@mathieuartu mathieuartu self-assigned this Feb 28, 2025
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "24.1.0-preview-1b0ea93a",
  "@metamask-previews/address-book-controller": "6.0.3-preview-1b0ea93a",
  "@metamask-previews/announcement-controller": "7.0.3-preview-1b0ea93a",
  "@metamask-previews/approval-controller": "7.1.3-preview-1b0ea93a",
  "@metamask-previews/assets-controllers": "51.0.2-preview-1b0ea93a",
  "@metamask-previews/base-controller": "8.0.0-preview-1b0ea93a",
  "@metamask-previews/bridge-controller": "1.0.0-preview-1b0ea93a",
  "@metamask-previews/bridge-status-controller": "1.0.0-preview-1b0ea93a",
  "@metamask-previews/build-utils": "3.0.3-preview-1b0ea93a",
  "@metamask-previews/composable-controller": "11.0.0-preview-1b0ea93a",
  "@metamask-previews/controller-utils": "11.5.0-preview-1b0ea93a",
  "@metamask-previews/earn-controller": "0.5.0-preview-1b0ea93a",
  "@metamask-previews/ens-controller": "15.0.2-preview-1b0ea93a",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-1b0ea93a",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-1b0ea93a",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-1b0ea93a",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-1b0ea93a",
  "@metamask-previews/keyring-controller": "19.2.1-preview-1b0ea93a",
  "@metamask-previews/logging-controller": "6.0.4-preview-1b0ea93a",
  "@metamask-previews/message-manager": "12.0.1-preview-1b0ea93a",
  "@metamask-previews/multichain": "3.0.0-preview-1b0ea93a",
  "@metamask-previews/multichain-network-controller": "0.1.2-preview-1b0ea93a",
  "@metamask-previews/multichain-transactions-controller": "0.5.0-preview-1b0ea93a",
  "@metamask-previews/name-controller": "8.0.3-preview-1b0ea93a",
  "@metamask-previews/network-controller": "22.2.1-preview-1b0ea93a",
  "@metamask-previews/notification-services-controller": "1.0.0-preview-1b0ea93a",
  "@metamask-previews/permission-controller": "11.0.6-preview-1b0ea93a",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-1b0ea93a",
  "@metamask-previews/phishing-controller": "12.4.0-preview-1b0ea93a",
  "@metamask-previews/polling-controller": "12.0.3-preview-1b0ea93a",
  "@metamask-previews/preferences-controller": "15.0.2-preview-1b0ea93a",
  "@metamask-previews/profile-sync-controller": "8.1.1-preview-1b0ea93a",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-1b0ea93a",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-1b0ea93a",
  "@metamask-previews/remote-feature-flag-controller": "1.5.0-preview-1b0ea93a",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-1b0ea93a",
  "@metamask-previews/signature-controller": "23.2.1-preview-1b0ea93a",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-1b0ea93a",
  "@metamask-previews/transaction-controller": "46.0.0-preview-1b0ea93a",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-1b0ea93a"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant