Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprioritize SDK content #1200

Merged
merged 2 commits into from
Mar 10, 2024
Merged

Deprioritize SDK content #1200

merged 2 commits into from
Mar 10, 2024

Conversation

alexandratran
Copy link
Contributor

This PR:

  • Removes the "SDK" label from the top navigation.
  • Moves "Use MetaMask SDK" category lower in the "How to" category.
  • Removes the SDK as a third-party library option for detecting multiple wallets (there's still a section in the Wallet Interoperability concepts page explaining the SDK EIP-6963 functionality).
  • Removes the SDK options from the quickstarts.

Fixes #1196

@alexandratran alexandratran requested review from a team as code owners March 8, 2024 18:01
@alexandratran alexandratran requested a review from Montoya March 8, 2024 18:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Preview published: 1196-deprioritize-sdk

@alexandratran alexandratran requested a review from joaniekube March 8, 2024 18:16
joaniekube
joaniekube approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@joaniekube joaniekube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

Preview published: 1196-deprioritize-sdk

@subhamkumarr
Copy link
Contributor

LGTM

@Montoya Montoya merged commit 094b68c into main Mar 10, 2024
8 checks passed
@Montoya Montoya deleted the 1196-deprioritize-sdk branch March 10, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Montoya Montoya Montoya approved these changes

@subhamkumarr subhamkumarr subhamkumarr approved these changes

@joaniekube joaniekube joaniekube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprioritize SDK content
4 participants
@alexandratran @subhamkumarr @Montoya @joaniekube