Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cp-12.13.0 handle array image edge cases #30494

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Feb 21, 2025

Description

Ensures that we handle array images correctly be defaulting to their first image

Open in GitHub Codespaces

Related issues

Fixes: https://consensys.slack.com/archives/C8RSKCNCD/p1739984618053419

Manual testing steps

  1. Use Flask Build > Enable Watched Accounts
  2. Add watched address that owns this NFT: https://polygonscan.com/token/0x4b22c268e3f7f643686e0dfb160b40fe5328cccd?a=0x397d7171504776AD3d5f578ce772914539E28a49 (contract: 0x4b22C268E3f7f643686E0dfB160B40fE5328cccD, TokenID: 6822)
  3. Select this watched address and navigate to NFT page.
  4. Expect NFT to render - (expected image: ipfs://bafybeidgklvljyifilhtrxzh77brgnhcy6s2wxoxqc2l73zr2nxlwuxfcy)

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

it ensures that we handle array images correctly be defaulting to their first image
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Prithpal-Sooriya Prithpal-Sooriya force-pushed the fix-handle-array-image-edge-case branch from d535db3 to 18088c1 Compare February 21, 2025 17:26
@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as ready for review February 21, 2025 17:33
@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners February 21, 2025 17:33
gambinish
gambinish previously approved these changes Feb 21, 2025
Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with a small comment

This sneaked through while I attempted to synchronise our types. We will need a separate task to do this.
gambinish
gambinish previously approved these changes Feb 21, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [e66903b]
Page Load Metrics (1782 ± 111 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53319771670290139
domContentLoaded152725581746228109
load155926261782231111
domInteractive258944199
backgroundConnect13120452512
firstReactRender1478372311
getState6110262914
initialActions01000
loadScripts10802006130520096
setupStore66218188
uiStartup169636102056382183
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 762 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [9433a94]
Page Load Metrics (1716 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37620731655342164
domContentLoaded14102060168517182
load14272071171617685
domInteractive248735136
backgroundConnect872302010
firstReactRender1477312411
getState46217199
initialActions01000
loadScripts10051479123613665
setupStore77516199
uiStartup16852368197518488
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 762 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@Prithpal-Sooriya Prithpal-Sooriya changed the title fix: handle array image edge cases fix: cp-12.13.0 handle array image edge cases Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants