-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cp-12.13.0 handle array image edge cases #30494
Open
Prithpal-Sooriya
wants to merge
8
commits into
main
Choose a base branch
from
fix-handle-array-image-edge-case
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it ensures that we handle array images correctly be defaulting to their first image
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
d535db3
to
18088c1
Compare
gambinish
reviewed
Feb 21, 2025
gambinish
previously approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a small comment
This sneaked through while I attempted to synchronise our types. We will need a separate task to do this.
gambinish
previously approved these changes
Feb 21, 2025
…x-handle-array-image-edge-case
…k/metamask-extension into fix-handle-array-image-edge-case
Builds ready [e66903b]
Page Load Metrics (1782 ± 111 ms)
Bundle size diffs
|
Builds ready [9433a94]
Page Load Metrics (1716 ± 85 ms)
Bundle size diffs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that we handle array images correctly be defaulting to their first image
Related issues
Fixes: https://consensys.slack.com/archives/C8RSKCNCD/p1739984618053419
Manual testing steps
0x4b22C268E3f7f643686E0dfB160B40fE5328cccD
, TokenID:6822
)ipfs://bafybeidgklvljyifilhtrxzh77brgnhcy6s2wxoxqc2l73zr2nxlwuxfcy
)Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist