Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Mina_block.{Stable.Latest.t, t} #16496

Open
wants to merge 1 commit into
base: georgeee/proof-cache-tag-decouple-mina_block-base
Choose a base branch
from
Open

Decouple Mina_block.{Stable.Latest.t, t} #16496

wants to merge 1 commit into from

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Jan 21, 2025 •
edited
Loading

Remove Stable.Latest.t = t from interfaces. This is a preparation step for removing the equality in the implementation as well.

Step towards #16582

Explain how you tested your changes:

  • It's a refactoring that doesn't change any behavior
  • It compiles :)

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested a review from a team as a code owner January 21, 2025 21:33
@georgeee georgeee mentioned this pull request Jan 21, 2025
Open
7 tasks
@georgeee georgeee force-pushed the georgeee/proof-cache-tag-17-decouple-mina-block-validated-types branch from 8c5a8c3 to 3a9d7df Compare February 5, 2025 18:45
Base automatically changed from georgeee/proof-cache-tag-17-decouple-mina-block-validated-types to compatible February 6, 2025 12:00
@georgeee georgeee force-pushed the georgeee/proof-cache-tag-19-decouple-mina-block-types branch from e43844d to 057ad38 Compare February 6, 2025 13:59
@georgeee georgeee changed the base branch from compatible to georgeee/proof-cache-tag-12-headers-in-best-tip-prover-verify February 19, 2025 19:46
@georgeee georgeee force-pushed the georgeee/proof-cache-tag-19-decouple-mina-block-types branch from dc75457 to ddff24b Compare February 19, 2025 19:46
@georgeee georgeee force-pushed the georgeee/proof-cache-tag-12-headers-in-best-tip-prover-verify branch from 2410660 to ce1deab Compare February 21, 2025 08:58
@georgeee
Decouple Mina_block.{Stable.Latest.t, t}
ca750bc 
Remove `Stable.Latest.t = t` from interfaces. This is a preparation step
for removing the equality in the implementation as well.
@georgeee georgeee changed the base branch from georgeee/proof-cache-tag-12-headers-in-best-tip-prover-verify to georgeee/proof-cache-tag-decouple-mina_block-base February 21, 2025 09:01
@georgeee georgeee force-pushed the georgeee/proof-cache-tag-19-decouple-mina-block-types branch from ddff24b to ca750bc Compare February 21, 2025 09:02
This was referenced Feb 21, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@georgeee