Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to invalidating filter when receiving mod updates. #1417

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

Holt59
Copy link
Member

@Holt59 Holt59 commented Feb 21, 2021

  1. I clean a bit the NXM-update slots because I did not like that sender stuff, so I just used a lambda.
    • The signal was incorrect (the template type of QFutureWatcher did not match), but I guess that was partially fine...
  2. I switched back to invalidate in some cases, but I only invalidate at the end (there is no point invalidating for all mods).
    • I removed invalidate initially because it was breaking selection, etc., which was annoying. Now it does not, (probably) because I modified the by-priority proxy to not reset the model when not required.

I have no clue if this actually will fix the issue some users are experiencing because I still cannot reproduce it.

@Holt59 Holt59 changed the base branch from master to 2_4_x February 21, 2021 20:27
@Al12rs
Copy link
Member

Al12rs commented Feb 21, 2021

nxmModInfoAvailable() is still using notifyChange(), while before it was using invalidate. nxmModInfoAvailable() is called in case that the mod file is marked as deleted or Old but there is not a new file that is marked to be successor, so MO2 requests the general mod info for the mod version.

@Holt59
Copy link
Member Author

Holt59 commented Feb 21, 2021

nxmModInfoAvailable() is still using notifyChange(), while before it was using invalidate. nxmModInfoAvailable() is called in case that the mod file is marked as deleted or Old but there is not a new file that is marked to be successor, so MO2 requests the general mod info for the mod version.

Yes I know, but I think notifyChange is sufficient here. The one that is bothering me is https://github.com/ModOrganizer2/modorganizer/pull/1417/files#diff-c72b037f3ac7abbd3d0ee519b6f456013a9bbf5a59df16308939320c04970447R2831, but since I have no clue why it was (is?) needed, I added it back. The other I replaced was in a if (foundUpdate), similar to the one you already fixed. I don't really now why it would be needed in the else since you get the nxmModInfoAvailable afterward.

@Holt59 Holt59 added this to the 2.4.1 milestone Feb 23, 2021
@Holt59 Holt59 merged commit f8b66c5 into ModOrganizer2:2_4_x Feb 23, 2021
@Holt59 Holt59 deleted the fix-update-filter branch May 7, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants