Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Ports the port of traitor backstories from yogstation from beestation #4481

Closed
wants to merge 20 commits into from

Conversation

cowbot92
Copy link

@cowbot92 cowbot92 commented Dec 6, 2024

Almost all credit goes to the original PR: BeeStation/BeeStation-Hornet#9126
Credit for whatever changes we originally made go from here yogstation13/Yogstation#21836

Special thanks to @Chubbygummibear for TGUI help and themes

About The Pull Request

Adds traitor backstories, and factions and the basic framework for people to add more of them as they would so please.

Current Included Backstories/Factions

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

Current Themes

Independent -
image

Donk -
image

Waffle-
image

Cyber Sun-
image

Vahlen-
image

Gorlex-
image

S.E.L.F-
image

Bosyn-Powell-
image

Why It's Good For The Game

I believe this is a feature which can help people better immerse themselves in the role-playing experience of being a 'traitor', and while you can certainly say 'oh yeah im from x group' having it physically be there adds a little bit of extra oomf. Additionally this can be used to adjust discounts in the future and affect game play if needed (it does not affect ANY game play as of now)

Changelog

🆑
add: Added traitor backstories/factions
/:cl:

@Oscari-pog
Copy link

Forced into it, Fun

@Kitsunemitsu Kitsunemitsu added the Expansion Some addons for a big new thing label Dec 9, 2024
Copy link
Member

@Absolucy Absolucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly some nitpicks, but going to testmerge it

@cowbot92
Copy link
Author

UI has a lot of empty space that kinda looks iffy, and the "Renegotiate Objectives" button seems to be gone (im dumb and forgot that latter was in the uplink)

2025-01-17 (1737155145) ~ dreamseeker

What else would you like me to add?

@Shoddd
Copy link
Collaborator

Shoddd commented Jan 20, 2025

these need to be addressed (second bit of report and comments) #4954

@Absolucy
Copy link
Member

What else would you like me to add?

@cowbot92 could just show faction / backstory stuff on the same page instead of having it as a tab, similar to the old one.

also yeah #4954 needs to be addressed (albeit ignore the bit about custom objectives, that's a part of the uplink)

@cowbot92
Copy link
Author

What else would you like me to add?

@cowbot92 could just show faction / backstory stuff on the same page instead of having it as a tab, similar to the old one.

also yeah #4954 needs to be addressed (albeit ignore the bit about custom objectives, that's a part of the uplink)

Ill open this at later date then and tweak it in the background

@cowbot92 cowbot92 closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expansion Some addons for a big new thing peak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants