Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range order fixes #286

Merged
merged 6 commits into from
May 21, 2024
Merged

Range order fixes #286

merged 6 commits into from
May 21, 2024

Conversation

grunch
Copy link
Member

@grunch grunch commented May 21, 2024

Fixes #276

  • Updated cargo.toml for mostro-core 5.13
  • Removed not null conditions from db file to avoid errors on db entry creation due to max_amount and min_amount null possible value
  • If order is with range now we check if sats amount conversion is inside limit for both values, if order is no range order same logic as before
  • Implemented same logic of lnP2P bot to diminish max amount or ranged order and mark it as successful ( this part need to be fully tested and improved in style )

Missing things in my mind:

  • TakeBuy and TakeSell checks if amount received is in the range of order and in case send back a message to user.
  • Testing everything

@grunch grunch mentioned this pull request May 21, 2024
@grunch grunch marked this pull request as ready for review May 21, 2024 19:55
@grunch grunch merged commit fd3e8c4 into main May 21, 2024
1 check passed
@arkanoider arkanoider deleted the range-order-fixes branch May 21, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rango de cantidades al ordenar.
1 participant