Fix: Improves handle of messages in privacy mode

[grunch]

Handle correctly messages with payload without signature

Summary by CodeRabbit

• Bug Fixes
  • Improved event processing error handling
  • Enhanced signature verification logic
  • Added more robust deserialization error management
  • Updated logic to handle optional signatures during verification

[coderabbitai]

Walkthrough

The pull request introduces modifications to the event processing logic in the src/app.rs file. The changes focus on improving signature verification and error handling during event content deserialization. The key modifications include changing the signature tuple type to allow for optional signatures, updating the signature verification logic to conditionally check signatures, and implementing more robust error handling during deserialization.

Changes

File	Change Summary
src/app.rs	- Modified run function signature tuple from (Message, Signature) to (Message, Option<Signature>) - Updated signature verification to check for Some(sig) - Added conditional signature verification based on sender and rumor pubkeys - Replaced unwrap() with match statement for improved error handling

Sequence Diagram

sequenceDiagram
    participant Event
    participant Deserializer
    participant SignatureVerifier
    
    Event->>Deserializer: Attempt to deserialize
    alt Deserialization Successful
        Deserializer->>SignatureVerifier: Check Optional Signature
        alt Signature Present and Pubkeys Differ
            SignatureVerifier->>SignatureVerifier: Verify Signature
        else No Signature or Same Pubkeys
            SignatureVerifier-->>Event: Continue Processing
        end
    else Deserialization Failed
        Deserializer-->>Event: Log Error
    end

Loading

Poem

🐰 A Rabbit's Ode to Robust Code 🔍

In bytes of data, signatures dance,
Optional now, with a careful glance,
No more unwraps that might just break,
Graceful errors, a safer take!

Hop, hop, hooray for code so bright! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc8fc67 and 8ddc162.

📒 Files selected for processing (1)

• src/app.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app.rs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6759995 and dc8fc67.

📒 Files selected for processing (1)

• src/app.rs (1 hunks)

🔇 Additional comments (1)

src/app.rs (1)

253-261: Good transition to support optional signatures.

Switching from (Message, Signature) to (Message, Option<Signature>) supports the new privacy requirement and gracefully handles events without a signature.

As a further enhancement, you might want to add unit tests or integration tests covering the None signature scenario to ensure the code handles that flow exactly as intended.