Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Reset #167

Closed
ghost opened this issue Oct 29, 2012 · 5 comments
Closed

Sort Reset #167

ghost opened this issue Oct 29, 2012 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Oct 29, 2012

When you've set an initial order (desc) or use save sort, and then click the column with sortReset set to true, it immediately resets. It seems that this is built-in to reset after clicking on a desc column, but instead shouldn't it reset on third click? So after both ascending and descending have been shown.

@Mottie
Copy link
Owner

Mottie commented Oct 30, 2012

Thanks! I'll have a look.

@Mottie
Copy link
Owner

Mottie commented Nov 14, 2012

Hi @wesleyh!

Sorry, I've been very busy lately, but I've finally had a look at this and it seems to work properly to me.

I set up this demo where I clicked on the first column and second column and both work as they should. Am I missing some option?

I should also note that I don't think the saveSort works properly in jsFiddle as the result frame is constantly changing and saveSort uses the URL for saving.

@ghost
Copy link
Author

ghost commented Nov 15, 2012

Sorry for the confusion, I didn't mean the intial sort order on click, but an initial sort order on page load. (or via savesort)

@Mottie
Copy link
Owner

Mottie commented Nov 15, 2012

Can you please share your initialization code.

Mottie added a commit that referenced this issue Dec 26, 2012
@Mottie
Copy link
Owner

Mottie commented Jan 29, 2013

I'm guessing/hoping this issue has been resolved. Please feel free to reopen it if you continue to have problems.

@Mottie Mottie closed this as completed Jan 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant