Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node to version 20 #11773

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Bump node to version 20 #11773

merged 7 commits into from
Jan 31, 2024

Conversation

jhonatan-lopes
Copy link
Contributor

Description

Bumps node to version 20 and runs a npm audit fix

Link to sample test page:
Related PRs/issues: #11641

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Extra thanks for running npm audit fix @jhonatan-lopes . I noticed that .github/workflows/visual-regression-testing.yml still needs to be updated. Once that's done, this PR is good to go!

Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, meant to choose "request changes"

@jhonatan-lopes
Copy link
Contributor Author

Thanks @mmmavis! I totally missed that one

Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jhonatan-lopes jhonatan-lopes merged commit cb1317b into main Jan 31, 2024
6 checks passed
@jhonatan-lopes jhonatan-lopes deleted the chore/upgrade-npm-and-node-deps branch January 31, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants