Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and refactor side wide shared JS code #4387

Merged
merged 14 commits into from
Mar 26, 2020
Merged

Clean up and refactor side wide shared JS code #4387

merged 14 commits into from
Mar 26, 2020

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Mar 24, 2020 •
edited
Loading

Closes #3055

Created a new common directory under /js and moved side-wide shared JS code to there. (Note: better naming welcome :D)

Reviewing this PR commit by commit might make the review process easier.

@patjouk patjouk temporarily deployed to foundation-s-issue-3055-xpc0wl March 24, 2020 00:31 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 24, 2020 07:11 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 24, 2020 07:36 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 24, 2020 07:36 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 24, 2020 17:28 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 24, 2020 17:34 Inactive
@mmmavis mmmavis changed the title (WIP) Cleanup and refactor side wide shared JS code Cleanup and refactor side wide shared JS code Mar 24, 2020
@mmmavis mmmavis marked this pull request as ready for review March 24, 2020 17:35
@mmmavis mmmavis requested a review from Pomax March 24, 2020 17:53
@mmmavis mmmavis changed the title Cleanup and refactor side wide shared JS code Clean up and refactor side wide shared JS code Mar 24, 2020
Pomax
Pomax suggested changes Mar 24, 2020
View reviewed changes
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 24, 2020 20:25 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 24, 2020 21:47 Inactive
@mmmavis mmmavis requested a review from Pomax March 24, 2020 22:17
Pomax
Pomax suggested changes Mar 25, 2020
View reviewed changes
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 25, 2020 00:52 Inactive
@mmmavis mmmavis requested a review from Pomax March 25, 2020 00:52
@Pomax Pomax temporarily deployed to foundation-s-issue-3055-xpc0wl March 25, 2020 20:09 Inactive
Pomax
Pomax suggested changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits

@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 25, 2020 21:36 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 25, 2020 21:37 Inactive
@mmmavis mmmavis requested a review from Pomax March 25, 2020 21:37
Pomax
Pomax approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@Pomax Pomax temporarily deployed to foundation-s-issue-3055-xpc0wl March 26, 2020 16:34 Inactive
@mmmavis mmmavis temporarily deployed to foundation-s-issue-3055-xpc0wl March 26, 2020 18:08 Inactive
@mmmavis mmmavis merged commit 07d2aa0 into master Mar 26, 2020
@mmmavis mmmavis deleted the issue-3055-side-wide-script branch March 26, 2020 18:26
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pomax Pomax Pomax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out a way to deal with site-wide shared JS code
3 participants
@mmmavis @Pomax @patjouk