Fix to transfer inventory from old Storage Minecart to new one. Fixes #326 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Storage Minecarts where portals emptied the contents when they went through.
Removed empty Lines
Fixed the issue of destroyed Items for Hopper Minecarts
| Vehicle newVehicle = target.getWorld().spawn(target, event.getVehicle().getClass()); | ||
|
|
||
| // Gets inventory from old Cart | ||
| if (event.getVehicle() instanceof StorageMinecart || event.getVehicle() instanceof HopperMinecart) { |
There was a problem hiding this comment.
Should be vehicle instanceof InventoryHolder for maximum compatibility.
Thanks to @dumptruckman - Line 91 Should be vehicle instanceof InventoryHolder for maximum compatibility.
dumptruckman
changed the title
|
I don't like this solution because it has one major oversight. The Vehicle class provided by Bukkit extends Entity. That means that a Vehicle has more than just inventory that has to be worried about. For example, with this solution (and without it) regardless of what health the Vehicle had before entering a portal, it will always emerge at full health on the other side. Here is my proposed solution: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Problem that Items get destroyed when Storage or Hopper Minecarts go through a Portal.