Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if fetching an entry point results in an HTTP redirect #95

Merged
merged 4 commits into from
Jun 30, 2020

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou commented Jun 4, 2020

I ran into some small glitches when I tried to run subfont on https://netlify.com/ because it gets redirected to https://www.netlify.com/. This helps a bit -- roughly copied from bringhome.

Silences this weird warning:
 ⚠ WARN: https://netlify.com/ - Skipping https://netlify.com/ -- cannot write an empty file name to disc. Consider renaming it to index.html
@papandreou papandreou self-assigned this Jun 4, 2020
@papandreou papandreou requested a review from Munter June 4, 2020 22:20
@coveralls
Copy link

coveralls commented Jun 4, 2020

Pull Request Test Coverage Report for Build 338

  • 13 of 14 (92.86%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 89.382%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/subfont.js 13 14 92.86%
Files with Coverage Reduction New Missed Lines %
lib/subfont.js 1 84.5%
lib/subsetFonts.js 6 96.57%
Totals Coverage Status
Change from base Build 327: 0.07%
Covered Lines: 1006
Relevant Lines: 1077

💛 - Coveralls

@papandreou
Copy link
Collaborator Author

Made some further fixes so that the assetgraph root gets updated when all entry point access are redirected to another origin. Previously the tool would only output the subfont-generated files to the output dir in that case.

@Munter Munter merged commit 26277b1 into master Jun 30, 2020
@Munter Munter deleted the feature/warnOnEntryPointRedirect branch June 30, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants