Skip to content
This repository has been archived by the owner on Oct 17, 2022. It is now read-only.

chore: add lint checking for our markdown files in CI #205

Merged
merged 1 commit into from
May 4, 2022

Conversation

huitseeker
Copy link
Contributor

Importing a goodie from Sui: MystenLabs/sui#1766

@huitseeker huitseeker changed the title chore: add lint checking for out markdown files in CI chore: add lint checking for our markdown files in CI May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #205 (ba0ee00) into main (fecbfc9) will decrease coverage by 0.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   79.72%   78.75%   -0.98%     
==========================================
  Files          85       87       +2     
  Lines        9799    11219    +1420     
==========================================
+ Hits         7812     8835    +1023     
- Misses       1987     2384     +397     
Impacted Files Coverage Δ
test_utils/src/lib.rs 88.21% <0.00%> (-8.58%) ⬇️
network/src/lib.rs 92.30% <0.00%> (-7.70%) ⬇️
worker/src/worker.rs 75.00% <0.00%> (-4.50%) ⬇️
worker/src/tests/quorum_waiter_tests.rs 97.43% <0.00%> (-2.57%) ⬇️
primary/src/helper.rs 83.20% <0.00%> (-2.29%) ⬇️
worker/src/primary_connector.rs 86.48% <0.00%> (-1.75%) ⬇️
primary/src/primary.rs 0.62% <0.00%> (-0.80%) ⬇️
...ock_synchronizer/tests/block_synchronizer_tests.rs 93.11% <0.00%> (-0.69%) ⬇️
worker/src/synchronizer.rs 77.38% <0.00%> (-0.53%) ⬇️
worker/src/processor.rs 92.59% <0.00%> (-0.52%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fecbfc9...ba0ee00. Read the comment docs.

Copy link
Contributor

@akichidis akichidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome tool! Thanks for adding this 👍

issue-number: ${{ steps.last_issue.outputs.issue_number }}
labels: |
report
automated issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add the documentation label as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it independently (manually) as the issue is never deleted or re-created, this is just the tags the flow of the scanner, and I'd rather it selected on a pretty narrow set of tags.

@huitseeker huitseeker merged commit bb701fc into MystenLabs:main May 4, 2022
@huitseeker huitseeker deleted the ci-lint-checking branch January 21, 2023 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants