Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastx Authority] Deleted objects cause incorrect client reads #282

Closed
gdanezis opened this issue Jan 27, 2022 · 1 comment
Closed

[fastx Authority] Deleted objects cause incorrect client reads #282

gdanezis opened this issue Jan 27, 2022 · 1 comment
Labels
Type: Bug Something isn't working

Comments

@gdanezis
Copy link
Collaborator

When an object is deleted the fastx authority would remove it from its database. However an ObjectInfoRequest may still be used to get the parent TransactionDigest at a previous (existing) object version. However, the current logic below, would in addition to returning a cert, also try to read the latest object (which does not work) and return an Err with no info on the previous Transaction Digest of the object.

https://github.com/MystenLabs/fastnft/blob/3953018b06ebb405ff3b41b7e5f43df27149eda3/fastpay_core/src/authority.rs#L415-L419
@gdanezis gdanezis added the Type: Bug Something isn't working label Jan 27, 2022
@gdanezis gdanezis added this to the Milestone 3 milestone Jan 27, 2022
@gdanezis gdanezis changed the title [fastx Authority] Delete objects cause incorrect client reads [fastx Authority] Deleted objects cause incorrect client reads Jan 27, 2022
gdanezis pushed a commit that referenced this issue Jan 28, 2022
Created a delete test that fails due to a known bug (BUG(#282))
7af1690
gdanezis added a commit that referenced this issue Jan 29, 2022
@gdanezis
[fastx client] Add logic for a client to sync a cert to an authority,…
4a61ac0 
… and two authorities. (#285)

* Fix authority idempotency bug, and start work on sync_authority_source_to_destination
* Added safer sync function
* Refined the error returned when signatures fail.
* Add tests for sync, and report BUGs.
* Created a delete test that fails due to a known bug (BUG(#282))

Co-authored-by: George Danezis <[email protected]>
@gdanezis gdanezis mentioned this issue Jan 29, 2022
Merged
@gdanezis
Copy link
Collaborator Author

Note that PR #311 circumvents this bug for authority to authority sync, but does not fix it.

@gdanezis gdanezis modified the milestones: Milestone 3, GDC Jan 30, 2022
@gdanezis gdanezis mentioned this issue Jan 30, 2022
Merged
gdanezis added a commit that referenced this issue Jan 31, 2022
@gdanezis
[fastx authority api] Fix bug #282 relating to get_object_info of p…
e544299 
…otentially deleted objects (#315)

* Remove unused request_received_transfers_excluding_first_nth in ObjectOrderRequest.
* Rename to pending_order
* Rename parent_certificate
* Changed the structure of ObjectInfoResponse
* Use helper function to get object

Co-authored-by: George Danezis <[email protected]>
@gdanezis gdanezis closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdanezis