[fastx types] make size of Move's address type configurable
#44
Assignees
Comments
|
This is landed in Move repo: diem/move#10 |
amnn
added a commit
that referenced
this issue
Apr 4, 2024
…7043) ## Description Script extracts release notes in the new format where a single PR can contain different breaking changes for each functional area ## Test Plan Tested manually against a set of local commits. Example output from `generate` command: ``` ## Protocol Sui Protocol Version in this release: 43 #42: Bumped protocol version to 42 #9001: You get a release note ## Nodes (Validators and Full nodes) #44: ## Indexer #9001: You get a release note ## JSON-RPC #42: Made some sweeping changes, to: - Foo - Bar ## CLI #9001: Everybody gets release notes ``` Example output from `check` command (if there are issues): ``` Found issues with release notes in amnn/test-release-notes^: - 'Protocol' has a release note but is not checked: An important message, can't miss! - 'Nodes (Validators and Full nodes)' is checked but has no release note. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Move account addresses are 16 bytes. We would like to make them the same size as fastX authenticators (i.e.,
FastPayAddress), and (ideally) fastXObjectID's too. We haven't decided on the size of either of those types yet, but they will likely need to be >= 20 bytes for safety (e.g., a 32 byte hash truncated to the shortest length that is safe w.r.t collisions).Whatever length(s) we chose, we need to be able to adjust Move addresses accordingly. The size of Move addresses is determined by this constant in the Diem codebase. We need to tweak it via one mechanism or another. Some ideas:
cargomagic to set a constant at compile-time via a build config (preferred long-term solution)cargo's patch feature to override the address length locally (probably the quickest short term solution)The text was updated successfully, but these errors were encountered: