Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Authority] Remove standalone next sequence from store struct #1059

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

gdanezis
Copy link
Collaborator

Given the latest logic for maintaining batches and a local sequence of commands, we do not need the atomic next_sequence_number in the store any more. So this PR removes it, and its initialisation.

@asonnino asonnino self-requested a review March 24, 2022 14:58
Copy link
Contributor

@asonnino asonnino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdanezis gdanezis merged commit 4b1c7e6 into main Mar 24, 2022
@gdanezis gdanezis deleted the store-next-seq branch March 24, 2022 14:59
@oxade
Copy link
Contributor

oxade commented Mar 24, 2022

Given the latest logic for maintaining batches and a local sequence of commands, we do not need the atomic next_sequence_number in the store any more. So this PR removes it, and its initialisation.

Nice observation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants