Fix Writing a package section of Move doc #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Writing a package section of Move doc
huitseeker
added
the
Type: Documentation
huitseeker
reviewed
Mar 31, 2022
awelc
requested changes
Apr 4, 2022
doc/src/build/move.md
Outdated
| described earlier: | ||
| described earlier. | ||
|
|
||
| Navigate (`cd`) into the `sui` directory and run: |
There was a problem hiding this comment.
This does not reflect the code structure as the my_move_package directory is "parallel" to `sui' in the hierarchy diagram.
Reading further I can see that this is intentional, but I am not sure if this is the best idea. The intention behind these directories being "parallel" was to avoid "polluting" the cloned Sui repository this way and in my opinion it's a cleaner approach.
Either way, we need to change the dir structure diagrams or the (new) text for consistency.
There was a problem hiding this comment.
Ahh, I see now. Let me rework this change given that intention. Thanks!
There was a problem hiding this comment.
I've now put this back in order. Sorry for my confusion.
Updating change to reflect `my_move_package` and `sui` directories are parallel
awelc
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Writing a package section of Move doc