Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REST Server] Show clear error message #1336

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[REST Server] Show clear error message #1336

merged 1 commit into from
Apr 13, 2022

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented Apr 12, 2022

The user will get a vague message if they forget to run sui genesis before ./rest_sever:

➜ ./rest_server
Error: No such file or directory (os error 2)

After this PR:

➜ ./rest_server
Error: Failed to read config file at "/Users/cl/.sui/sui_config/gateway.conf": No such file or directory (os error 2). 
Have you run `sui genesis` first?

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1336 (1a965d2) into main (4d09cb9) will increase coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
+ Coverage   81.72%   81.77%   +0.04%     
==========================================
  Files         100      100              
  Lines       20966    20972       +6     
==========================================
+ Hits        17134    17149      +15     
+ Misses       3832     3823       -9     
Impacted Files Coverage Δ
sui/src/rest_server.rs 23.43% <0.00%> (-0.34%) ⬇️
sui_core/src/authority/temporary_store.rs 83.52% <0.00%> (-0.40%) ⬇️
...i_programmability/verifier/src/id_leak_verifier.rs 91.03% <0.00%> (ø)
sui_core/src/authority_aggregator.rs 87.43% <0.00%> (+0.72%) ⬆️
sui_core/src/safe_client.rs 60.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206f9e8...1a965d2. Read the comment docs.

@666lcz 666lcz merged commit 7bb3621 into main Apr 13, 2022
@666lcz 666lcz deleted the chris/fix-rest-error branch April 13, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants