Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename authority -> validator #1398

Merged
merged 10 commits into from
Apr 15, 2022
Merged

chore: rename authority -> validator #1398

merged 10 commits into from
Apr 15, 2022

Conversation

huitseeker
Copy link
Contributor

To get us started!

@huitseeker huitseeker requested a review from Clay-Mysten April 15, 2022 11:49
oxade
oxade reviewed Apr 15, 2022
View reviewed changes
doc/src/build/authorities.md
@@ -1,33 +1,33 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to rename this file to validators.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voluntarily, I've left that to a further PR along with the code changes. This makes review easier:
https://github.com/MystenLabs/sui/pull/1398/files#diff-4bf78b90fcc082845477a30625a3a7d864cac80492da8e1621ba853ff5e19a30R11

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha!

@Clay-Mysten
Update authorities.md
58194bf 
Fix instances of "an validator" with proper article
@Clay-Mysten
Update objects.md
55fb879 
Fix instance of "an validator" with proper article
@Clay-Mysten
Update about-sui.md
de08128 
Fix instance of "an validator" with proper article
@Clay-Mysten
Update how-sui-works.md
9954c1f 
Fix instance of "an validator" with proper article
@Clay-Mysten
Update sui-compared.md
78caea9 
Fix instances of "an validator" with proper article
@Clay-Mysten
Update sui-glossary.md
92395b3 
Fix instance of "an validator" with proper article
@Clay-Mysten
Update sui-security.md
70ac2c4 
Fix instance of "an validator" with proper article
@Clay-Mysten
Update why-move.md
e88fdee 
Fix instances of "an validator" with proper article
Clay-Mysten
Clay-Mysten approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, Francois! I've fixed instances of "an validator" in direct commits to your PR. Thanks again!

@Clay-Mysten Clay-Mysten linked an issue Apr 15, 2022 that may be closed by this pull request
Replace Authorities with Validators throughout #1364
Closed
@Clay-Mysten Clay-Mysten added the Type: Documentation Improvements or additions to documentation label Apr 15, 2022
@Clay-Mysten Clay-Mysten added this to the DevNet milestone Apr 15, 2022
@Clay-Mysten Clay-Mysten enabled auto-merge (squash) April 15, 2022 17:47
@Clay-Mysten Clay-Mysten merged commit 33eae0c into MystenLabs:main Apr 15, 2022
@huitseeker huitseeker deleted the authorities_rename branch January 21, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxade oxade oxade left review comments

@Clay-Mysten Clay-Mysten Clay-Mysten approved these changes

Assignees
No one assigned
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
DevNet
Development

Successfully merging this pull request may close these issues.

Replace Authorities with Validators throughout
3 participants
@huitseeker @oxade @Clay-Mysten