[follower api] Augments the follower API with transaction info #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
+ Coverage 82.19% 82.31% +0.12%
==========================================
Files 104 103 -1
Lines 21145 21100 -45
==========================================
- Hits 17380 17369 -11
+ Misses 3765 3731 -34
Continue to review full report at Codecov.
|
velvia
reviewed
Apr 19, 2022
|
Once we have a multi-get for getting transaction info from a vector of transactions we can adapt it to use that. |
gdanezis
force-pushed
the
follower-augment-transaction-info
branch
from
eb7eaa2 to
e1b92b0
Compare
…ading the transactions information
gdanezis
force-pushed
the
follower-augment-transaction-info
branch
from
e1b92b0 to
57a15a0
Compare
longbowlu
added a commit
that referenced
this pull request
Apr 22, 2022
* refactor * clean up * refactor rebase * rebase * rebase * add how-to * format * lint * don't pop key, copy it * Add a safe client function that augments the follower API with downloading the transactions information (#1446) Co-authored-by: George Danezis <[email protected]> * Removing dev-addresses from Move.toml (#1536) There is no undefined address in the [addresses] section (e.g. AddressToBeFilledIn = "_") so having a [dev-addresses] section is not necessary. * [move][adapter] Static init rules (#1532) - Made init rules static - The existence of the function is optional - The function must be named 'init' - The function must be private - The function can have a single parameter, &mut TxContext - Alternatively, the function can have zero parameters * adds a counter example (#1539) * sui: reorganize binaries * wallet: log git revision on start * Refactor Build index by common user workflow (#1530) * Refactor Build index by common user workflow * Update index.md Fix paths missing Markdown file extension * Update index.md (#1545) Removing tutorial series until ready * Update index.md Remove version from API link Capitalize REST * comments and add unwind logic for process * fix: remove one unneeded instance of key_pair.copy() * fix: remove three unneeded instances of key_pair.copy() * fix: remove one unneeded instance of key_pair.copy() * refactor rebase * rebase * refactor * rebase * rebase * add how-to * lint * don't pop key, copy it * rebase * Update index.md Remove version from API link Capitalize REST * rebase Co-authored-by: Lu Zhang <[email protected]> Co-authored-by: George Danezis <[email protected]> Co-authored-by: George Danezis <[email protected]> Co-authored-by: jaredcosulich <[email protected]> Co-authored-by: Todd Nowacki <[email protected]> Co-authored-by: Damir S <[email protected]> Co-authored-by: Brandon Williams <[email protected]> Co-authored-by: Clay-Mysten <[email protected]> Co-authored-by: François Garillot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a
safe_clientfunction that augments the follower API stream with a call to download eachtransaction infofor received digests.