[RPC server] - add get transaction endpoint #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkuo
force-pushed
the
pat/jsonrpsee
branch
from
03ce330 to
96cad68
Compare
patrickkuo
force-pushed
the
pat/tx_endpoint
branch
from
df3fcc8 to
a182097
Compare
patrickkuo
force-pushed
the
pat/jsonrpsee
branch
from
b79c756 to
190f005
Compare
patrickkuo
force-pushed
the
pat/tx_endpoint
branch
from
69079bf to
7dc649a
Compare
stella3d
approved these changes
Apr 19, 2022
| @@ -986,6 +986,14 @@ impl<const ALL_OBJ_VER: bool, S: Eq + Serialize + for<'de> Deserialize<'de>> | |||
| Ok(transaction) | |||
| } | |||
|
|
|||
| pub fn get_certified_transaction( | |||
There was a problem hiding this comment.
previously this worked without modifying the authority store - did something change that requires this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add get_transaction to the GatewayAPI, RestAPI and JSON-RPC
Currently it return CertifiedTransactions, we can extend it to return SignedTransaction(signed unconfirmed) as well if needed.
*also replaced base64 with base64ct