Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port bug #1550

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Fix port bug #1550

merged 1 commit into from
Apr 23, 2022

Conversation

asonnino
Copy link
Contributor

@asonnino asonnino commented Apr 22, 2022 •
edited
Loading

We will eventually need to load the consensus committee from file like serious people, but for now this should fix the problem with minimal changes.

@asonnino asonnino added Type: Bug Something isn't working Priority: High Very important task, not blocking but potentially delaying milestones or limiting our offering Status: Needs Review PR is ready for review sui-node labels Apr 22, 2022
@asonnino asonnino requested review from patrickkuo and 666lcz April 22, 2022 23:57
@asonnino asonnino self-assigned this Apr 22, 2022
@asonnino asonnino enabled auto-merge (squash) April 22, 2022 23:58
@666lcz
Copy link
Contributor

666lcz commented Apr 23, 2022

We will eventually need to load the consensus committee from file like serious people,

Could you link/add an issue to track this?

@asonnino asonnino mentioned this pull request Apr 23, 2022
Open
@asonnino
Copy link
Contributor Author

We will eventually need to load the consensus committee from file like serious people,

Could you link/add an issue to track this?

#1553

@asonnino asonnino merged commit b8c7f90 into main Apr 23, 2022
@asonnino asonnino deleted the fix-port-reuse branch April 23, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@666lcz 666lcz 666lcz approved these changes

@patrickkuo patrickkuo Awaiting requested review from patrickkuo

Assignees

@asonnino asonnino

Labels
Priority: High Very important task, not blocking but potentially delaying milestones or limiting our offering Status: Needs Review PR is ready for review sui-node Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asonnino @666lcz @huitseeker