add object type to object info response #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awelc
approved these changes
Apr 23, 2022
666lcz
reviewed
Apr 23, 2022
There was a problem hiding this comment.
Do you mind updating
sui/sdk/typescript/src/types/objects.ts
Lines 12 to 15 in 62d08e8
|
Given that this goes to the wire, should we use enum instead of a string? |
patrickkuo
force-pushed
the
pat/add_object_type_to_object_info
branch
from
46c097c to
4522f0c
Compare
@666lcz I don't really know typescript, can you check if the changes looks ok? |
|
@666lcz does this PR looks ok to you? |
666lcz
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added object type to object info response for
sui_getObjectTypedInfoendpoint.