[Move] Fixed test function calling entry function and updated docs #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clay-Mysten
changed the title
lxfind
reviewed
Apr 28, 2022
doc/src/build/move.md
Outdated
| @@ -254,7 +252,7 @@ that it will do what it is intended to do.) | |||
|
|
|||
| In general, an entry function, must satisfy the following properties: | |||
|
|
|||
| - be public | |||
| - have `public(script)` visibility modifier | |||
| - have no return value | |||
| - have parameters ordered as follows: | |||
There was a problem hiding this comment.
This seems out of dated too.
lxfind
requested changes
May 10, 2022
awelc
force-pushed
the
aw/move-doc-public-fix
branch
from
fd21354 to
0e8102c
Compare
|
Can you remove the constraint on parameters order as well? |
awelc
added
Type: Documentation
Done! |
lxfind
approved these changes
May 11, 2022
|
Thanks, Adam! |
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
huitseeker
pushed a commit
that referenced
this pull request
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of
public(script)designation of entry points introduced a requirement to put the same modifier on the test functions calling entry functions. This fixes the problem for the Move quick start tutorial.