Direct execution #1656
Merged
Direct execution #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asonnino
commented
Apr 28, 2022
asonnino
commented
- Sui authorities immediatly attempt to execute consensus output without waiting for the client to tell them
- Update narwhal dependency
asonnino
assigned akichidis, gdanezis, huitseeker, LefKok, lxfind and asonnino and unassigned akichidis, huitseeker, lxfind, gdanezis, asonnino and LefKok
asonnino
requested review from
akichidis,
gdanezis,
huitseeker,
LefKok,
lxfind and
velvia
lxfind
reviewed
Apr 28, 2022
gdanezis
approved these changes
Apr 29, 2022
| } | ||
|
|
||
| /// Hash serialized consensus transactions. We do not need specific cryptographic properties except | ||
| /// only collision resistance. |
There was a problem hiding this comment.
You only need collision resistance for DoS protection, not correctness. A Hashtable disambiguates items with same hash through Eq
| state, | ||
| rx_consensus_input, | ||
| rx_consensus_output, | ||
| pending: HashMap::new(), |
There was a problem hiding this comment.
Advice: has a max size for this table -- it can be large, and after that return an error if there are too many pending things.
There was a problem hiding this comment.
Will do in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.