[Move] Constrain use of child object of shared object in Move calls #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
force-pushed
the
move-forbit-child-shared-object
branch
from
96841d7 to
3356f1b
Compare
sblackshear
reviewed
May 3, 2022
| current_module: ModuleId, | ||
| ) -> SuiResult { | ||
| // ancestor_map is a cache that remembers the top ancestor of each object. | ||
| // Top ancestor is the object at the top in the object ownership chain whose |
There was a problem hiding this comment.
Suggested change
| // Top ancestor is the object at the top in the object ownership chain whose | |
| // Top ancestor is the root at the top in the object ownership chain, which is always an address (not an object) |
There was a problem hiding this comment.
hmm that's actually not the intent. I am caching the last object in the object ownership chain (not an address).
lxfind
force-pushed
the
move-forbit-child-shared-object
branch
from
3356f1b to
7391a1a
Compare
sblackshear
approved these changes
May 4, 2022
| Owner::ObjectOwner(parent_id) => { | ||
| cur_id = parent_id.into(); | ||
| fp_ensure!( | ||
| cur_id != ancestor_stack[0], |
There was a problem hiding this comment.
Nice--IIUC, this also fixes nontrivial cycles (e.g., A owns B owns A....)
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
…1710) * Constrain use of child object of shared object in Move calls * Address feedback * Add TODO
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
…1710) * Constrain use of child object of shared object in Move calls * Address feedback * Add TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the constrain on how we use child objects of shared objects in Move calls.
Related to #1228
Fixes #1327
We require that one of the types must be defined in the same module.
This does not fully resolve the restricted transfer problem, but it at least makes sure people cannot attack on shared objects by arbitrarily manipulating the child objects.
Added a test, but I would hope for a more comprehensive test. I hope that soon the transaction test framework can support making Move calls so I could write a better test in Move.