Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate search bar from explorer home #1731

Merged
merged 2 commits into from
May 3, 2022
Merged

Remove duplicate search bar from explorer home #1731

merged 2 commits into from
May 3, 2022

Conversation

stella3d
Copy link
Contributor

@stella3d stella3d commented May 3, 2022

Bug number 7 in the bug bash sheet says we should remove the top search from the home page, but that's inconsistent with every other page on the site.

instead, i've removed the redundant search box included with the transactions element.

This also pluralizes "Latest Transactions".

Here's how the homepage looks after the change
image

@stella3d stella3d requested review from Jibz1, apburnie and 666lcz May 3, 2022 02:10
@stella3d stella3d self-assigned this May 3, 2022
Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to unblock but we should probably revisit this topic post devnet
This is supposed to be the landing page and thus it SHOULD look different from the other pages. We do want the search bar to be central and bigger for the landing page. (example1, example2)

@666lcz 666lcz merged commit 2b230cd into main May 3, 2022
@666lcz 666lcz deleted the dedupe-search branch May 3, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants