Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer] Fix smart contract rendering #1778

Merged
merged 3 commits into from
May 4, 2022
Merged

[explorer] Fix smart contract rendering #1778

merged 3 commits into from
May 4, 2022

Conversation

666lcz
Copy link
Contributor

@666lcz 666lcz commented May 4, 2022

Before:
There will be an error for rendering Move package object(example: https://explorer-internal-testing.s3-website-us-east-1.amazonaws.com/objects/8070E826B3668A048A59A095DE23EC26491CA2D9)
CleanShot 2022-05-04 at 01 42 31

After:
CleanShot 2022-05-04 at 01 42 22
CleanShot 2022-05-04 at 01 44 09

@666lcz 666lcz requested review from Jibz1, apburnie and stella3d May 4, 2022 08:47
@666lcz 666lcz changed the title Remove dead code [explorer] Fix smart contract rendering May 4, 2022
Copy link
Contributor

@apburnie apburnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@666lcz - We have a PR that covers this here: https://github.com/MystenLabs/sui/pull/1535/files.

The main change from this PR would be adding whitespace-pre to the CSS.

Would you like me to make a separate PR with the CSS changes?

@666lcz
Copy link
Contributor Author

666lcz commented May 4, 2022

@Andrew47 , if you examine the changed files, you will see the two PRs fix different things. This PR fixes the SDK <> backend, while your PR fixes the layout. We need both! Without this change, #1535 is not going to work

@666lcz 666lcz requested a review from apburnie May 4, 2022 15:47
@666lcz 666lcz requested a review from Clay-Mysten as a code owner May 4, 2022 18:16
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label May 4, 2022
Base automatically changed from sdk-dead to main May 4, 2022 18:17
@github-actions github-actions bot removed the Type: Documentation Improvements or additions to documentation label May 4, 2022
@666lcz
Copy link
Contributor Author

666lcz commented May 4, 2022

Rebase and re-test

@Andrew47 , note that the devnet gateway is currently down, if you would like to repro this locally,

  1. follow https://github.com/MystenLabs/sui/tree/main/explorer/client#connecting-to-local-rpc-server
    2.Use this command to publish a package
cd <sui repo>
wallet publish --path sui_programmability/tutorial --gas-budget 30000

Otherwise you can just watch the video below where I have thoroughly test the flow

CleanShot.2022-05-04.at.11.15.01.mp4

Copy link
Contributor

@apburnie apburnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the backend is down, the video proof will do for now.

@666lcz 666lcz merged commit f2a0e2b into main May 4, 2022
@666lcz 666lcz deleted the sdk-package branch May 4, 2022 18:42
punwai pushed a commit that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants