added txid to object page #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
reviewed
May 4, 2022
| @@ -223,12 +223,36 @@ function ObjectLoaded({ data }: { data: DataType }) { | |||
| /> | |||
| </div> | |||
| </div> | |||
| {data.data?.tx_digest && ( | |||
| <div> | |||
| <div>Transaction ID</div> | |||
There was a problem hiding this comment.
We might want to say something like "Last Transaction ID" to give more clarity on what this means.
Extra bonus points for a help tooltip that says "The ID of the last transaction to read or write this object. If this object has not been read or written by any transactions, this is the transaction that created the object".
stella3d
approved these changes
May 4, 2022
|
LGTM! Feel free to address the tooltip in a separate PR if we don't have that yet |
666lcz
approved these changes
May 4, 2022
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
* added txid to object page * fix test * fix test * rm tx_digest list and update rename Transaction ID to Last Transaction ID
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
* added txid to object page * fix test * fix test * rm tx_digest list and update rename Transaction ID to Last Transaction ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction ID added to Object page.
