Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Move Contract Display #1802

Merged
merged 9 commits into from
May 5, 2022
Merged

Update Move Contract Display #1802

merged 9 commits into from
May 5, 2022

Conversation

stella3d
Copy link
Contributor

@stella3d stella3d commented May 5, 2022

This is a merge of current main with @Andrew47 's draft PR for issue #1043 .

Now, Move contracts should display like this:
image

To test, start the explorer and visit the stdlib:
http://localhost:3000/objects/0000000000000000000000000000000000000002

@stella3d stella3d self-assigned this May 5, 2022
Copy link
Collaborator

@sblackshear sblackshear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@stella3d
Copy link
Contributor Author

stella3d commented May 5, 2022

original PR:
#1535

Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@stella3d stella3d merged commit ab35643 into main May 5, 2022
@stella3d stella3d deleted the 1043-pr branch May 5, 2022 05:27
longbowlu pushed a commit that referenced this pull request May 12, 2022
* improves handling of library objects

* improves handling of new lines

* removes swp file

* reinstate owner id to ensure tests pass

* initial merge with 1043 draft pr

* remove IS_LIBRARY for move display

* fix connected entities

* lint changes

Co-authored-by: Andrew Burnie <[email protected]>
punwai pushed a commit that referenced this pull request Jul 27, 2022
* improves handling of library objects

* improves handling of new lines

* removes swp file

* reinstate owner id to ensure tests pass

* initial merge with 1043 draft pr

* remove IS_LIBRARY for move display

* fix connected entities

* lint changes

Co-authored-by: Andrew Burnie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants