Revert "avoid using locked gas objects (#1768)" #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
approved these changes
May 5, 2022
oxade
approved these changes
May 5, 2022
|
I did not realize lock entries would exist even for objects which are not currently locked |
I forgot too! |
|
@lxfind , should we also merge this to the devnet branch? |
Already did! |
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
punwai
pushed a commit
that referenced
this pull request
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will resolve #1804
This reverts commit 1ee582c.
The issue is that it tries to read all transaction locks in the gateway to pick gas objects, but that basically means walking through every single object in the gateway, which would time out.